Sign in

← Software

TRIM / autotrim data-loss bugs (open)

titleTRIM / autotrim data-loss bugs (open)
recommendationinclude
directionboth-differ
areareliability
feature flag
openzfs version
summaryTwo open illumos issues: 18615 (TRIM can lose later writes on nvme/vioblk because DKIOCFREE is considered done before the disk acts; George Wilson, 2026-10/11) and 18384 (autotrim can corrupt a pool: the 15939 fix covered manual trim only; Jason King, 2026-08). Also 18599 (trim after log removal). OpenZFS's TRIM path differs and these were found on illumos.
impactSolnix on NVMe or virtio-blk risks checksum errors or silent damage from any TRIM until these land: 18615 hits manual 'zpool trim' as well as autotrim, 18384 hits autotrim only. Solnix creates every pool with autotrim=off, and the handbook says not to run 'zpool trim' on NVMe or virtio disks. sd (SATA/SAS) and file vdevs are not affected.
whyData-integrity bugs on the exact hardware Solnix targets (NVMe, virtio). Fixes are small and owned.
effortsmall
sourceshttps://www.illumos.org/issues/18615
https://www.illumos.org/issues/18384
https://www.illumos.org/issues/18599

What Solnix has done

  1. proposed Until illumos 18615 / 18384 land in the pin, Solnix images should ship with autotrim=off. (infra)
  2. planned Maintainer approved 2026-11-17: Solnix pools are created with autotrim=off (installer, image builders) until illumos 18615 and 18384 are in the pin; manual zpool trim stays available. (maintainer)
  3. in-progress Correction from the build team: 18615 is about any TRIM on blkdev disks (nvme, vioblk), manual zpool trim included, because vdev_disk_io_start() sends DKIOCFREE without DF_WAIT_SYNC. autotrim=off closes 18384 only. Done on solnix main 1435fbdc: autotrim=off at all 30 zpool create sites, scripts/test-autotrim-off.sh, and the handbook says not to run zpool trim on NVMe or virtio disks until 18615 is in the pin. sd (SATA/SAS) and file vdevs are not affected. Neither fix is on illumos master 4a5822399e, so the re-pin does not bring them; carrying the 18615 fix as a patch is open. (build-team)
  4. planned Maintainer approved 2026-11-18: carry the 18615 fix as Solnix patch 0014 with the pin1 re-pin, taken unchanged from its upstream review (George Wilson, code.illumos.org 5273 patch set 2, Code-Review+1 Matthew Ahrens), and help it land upstream with test evidence from the pin1 NVMe boot test. It applies at 4a5822399e with fuzz 0, not at the old pin. Drop it at the first re-pin that has 18615 upstream. autotrim=off stays until 18384 (review 4983) is in the pin. (maintainer)

Objections (0)

None.

Sign in to object to this item.